separate letsencrypt cron from collectinfo.pl cron

Submitted by george.asenov on Wed, 08/16/2017 - 08:04

Hello,

We need to separate the webmin cron job for collecting info from let's encrypt renew so we can separate schedule for both. Any suggestions how can that be done ?

As I see:

collectinfo is here /usr/libexec/webmin/virtual-server/collectinfo.pl

and at the end there is the line:

&apply_letsencrypt_cert_renewals();

webmin cron jobs are here /etc/webmin/webmincron/crons/

But is it sufficient to create new file like the one for collectinfo.pl in /etc/webmin/webmincron/crons/ and a .pl file in /usr/libexec/webmin/virtual-server/ with the line:

&apply_letsencrypt_cert_renewals();

or there is something more I need to do? Or if there is easier method please let me know.

Status: 
Active

Comments

Submitted by JamieCameron on Wed, 08/16/2017 - 22:36

You don't need a separate cron for this though - even though apply_letsencrypt_cert_renewals is called each time collectinfo.pl is run, it only renews the certs that are due.

Submitted by george.asenov on Thu, 08/17/2017 - 09:37

Yes it does but if for some reason the cert fail it try again and again and again every 15 minutes And send alot of emails to the customers. It will be better to renew all certs ones a day - if fail it will try the next. Bigger issue that we do not know when some cert fail and lets encrypt block the domains combination so we need to add additional domain to change the combination and workaround the limit.

Submitted by JamieCameron on Fri, 08/18/2017 - 19:33

Ok, that seems like a deeper issue that we need to fix properly rather than hacking the cron job.

Which Virtualmin version are you running there?

Submitted by george.asenov on Mon, 08/21/2017 - 08:55

Now we are on 5.07.gpl becasue we have add/modify files to add functionality and fix some issues we have in virtualmin different than let's encrypt. IS there a fix in the recent versions for Let's encrypt?

Submitted by JamieCameron on Mon, 08/21/2017 - 23:47

Maybe ... what was your specific problem?

Submitted by george.asenov on Tue, 08/22/2017 - 09:34

As I said most of the problems are users rewrites related, bu sometimes they failed couple of times then without anything changed only manual renew worked.

Submitted by JamieCameron on Tue, 08/22/2017 - 21:51

Rewrites we really can't do much about. Other issues related to excessive retries can only be fixed by a full Virtualmin upgrade.